Broken User Authentication
Last updated
# Unsafe Django code
from django.contrib.auth import authenticate
def login_view(request):
username = request.POST['username']
password = request.POST['password']
user = authenticate(request, username=username, password=password)
if user is not None:
# 로그인 성공
...
else:
# 로그인 실패
...# Safe Django code
from django.contrib.auth import authenticate, login
from django.contrib.auth.decorators import login_required
from django.conf import settings
import re
def login_view(request):
username = request.POST['username']
password = request.POST['password']
if not re.match(settings.USERNAME_REGEX, username) or not re.match(settings.PASSWORD_REGEX, password):
return HttpResponse("Invalid credentials", status=400)
user = authenticate(request, username=username, password=password)
if user is not None:
login(request, user)
# 로그인 성공
...
else:
# 로그인 실패
...
@login_required
def sensitive_view(request):
# 민감한 데이터 처리 로직
return HttpResponse("Sensitive data")# Unsafe Flask code
from flask import Flask, request
from werkzeug.security import check_password_hash
app = Flask(__name__)
@app.route('/login', methods=['POST'])
def login():
username = request.form['username']
password = request.form['password']
user = User.query.filter_by(username=username).first()
if user and check_password_hash(user.password, password):
# 로그인 성공
...
else:
# 로그인 실패
...# Safe Flask code
from flask import Flask, request, session, redirect, url_for
from werkzeug.security import check_password_hash
from flask_login import LoginManager, login_user, login_required
import re
app = Flask(__name__)
login_manager = LoginManager()
login_manager.init_app(app)
@app.route('/login', methods=['POST'])
def login():
username = request.form['username']
password = request.form['password']
if not re.match(USERNAME_REGEX, username) or not re.match(PASSWORD_REGEX, password):
return "Invalid credentials", 400
user = User.query.filter_by(username=username).first()
if user and check_password_hash(user.password, password):
login_user(user)
# 로그인 성공
return redirect(url_for('dashboard'))
else:
# 로그인 실패
return "Invalid credentials", 401
@login_required
@app.route('/dashboard')
def dashboard():
# 민감한 데이터 처리 로직
return "Sensitive data"# Unsafe FastAPI code
from fastapi import FastAPI, Request
app = FastAPI()
@app.post("/login")
async def login(request: Request):
form_data = await request.form()
username = form_data['username']
password = form_data['password']
user = get_user_by_username(username)
if user and user.password == password:
# 로그인 성공
...
else:
# 로그인 실패
...# Safe FastAPI code
from fastapi import FastAPI, Request, Depends, HTTPException
from fastapi.security import OAuth2PasswordBearer, OAuth2PasswordRequestForm
from fastapi_login import LoginManager
import re
app = FastAPI()
oauth2_scheme = OAuth2PasswordBearer(tokenUrl="token")
manager = LoginManager("SECRET", token_url="/auth/token")
@manager.user_loader
def load_user(username: str):
return get_user_by_username(username)
@app.post("/auth/token")
async def login(form_data: OAuth2PasswordRequestForm = Depends()):
username = form_data.username
password = form_data.password
if not re.match(USERNAME_REGEX, username) or not re.match(PASSWORD_REGEX, password):
raise HTTPException(status_code=400, detail="Invalid credentials")
user = load_user(username)
if user and user.password == password:
access_token = manager.create_access_token(data={"sub": username})
return {"access_token": access_token, "token_type": "bearer"}
else:
raise HTTPException(status_code=401, detail="Invalid credentials")
@app.get("/dashboard")
async def dashboard(current_user = Depends(manager)):
# 민감한 데이터 처리 로직
return {"detail": "Sensitive data"}